eslint

apps/dashboard/src/app/components/notifications/notifications.ts

@@ -82,11 +82,11 @@ export class NotificationsComponent {
     const diff = now.getTime() - timestamp.getTime();
     const minutes = Math.floor(diff / 60000);
 
-    if (minutes < 1) return 'Just now';
-    if (minutes < 60) return `${minutes}m ago`;
+    if (minutes < 1) {return 'Just now';}
+    if (minutes < 60) {return `${minutes}m ago`;}
 
     const hours = Math.floor(minutes / 60);
-    if (hours < 24) return `${hours}h ago`;
+    if (hours < 24) {return `${hours}h ago`;}
 
     const days = Math.floor(hours / 24);
     return `${days}d ago`;

apps/dashboard/src/app/pages/portfolio/portfolio.component.ts

@@ -161,8 +161,8 @@ export class PortfolioComponent implements OnInit, OnDestroy {
   }
 
   getPnLColor(value: number): string {
-    if (value > 0) return 'text-green-600';
-    if (value < 0) return 'text-red-600';
+    if (value > 0) {return 'text-green-600';}
+    if (value < 0) {return 'text-red-600';}
     return 'text-gray-600';
   }
 }

apps/dashboard/src/app/pages/strategies/components/drawdown-chart.component.ts

@@ -40,7 +40,7 @@ export class DrawdownChartComponent implements OnChanges {
   }
 
   private renderChart(): void {
-    if (!this.chartElement || !this.backtestResult) return;
+    if (!this.chartElement || !this.backtestResult) {return;}
 
     // Clean up previous chart if it exists
     if (this.chart) {

apps/dashboard/src/app/pages/strategies/components/equity-chart.component.ts

@@ -40,7 +40,7 @@ export class EquityChartComponent implements OnChanges {
   }
 
   private renderChart(): void {
-    if (!this.chartElement || !this.backtestResult) return;
+    if (!this.chartElement || !this.backtestResult) {return;}
 
     // Clean up previous chart if it exists
     if (this.chart) {

apps/dashboard/src/app/pages/strategies/components/performance-metrics.component.ts

@@ -278,27 +278,27 @@ export class PerformanceMetricsComponent {
 
   // Conditional classes
   getReturnClass(value: number): string {
-    if (value > 0) return 'positive';
-    if (value < 0) return 'negative';
+    if (value > 0) {return 'positive';}
+    if (value < 0) {return 'negative';}
     return '';
   }
 
   getRatioClass(value: number): string {
-    if (value >= 1.5) return 'positive';
-    if (value >= 1) return 'neutral';
-    if (value < 0) return 'negative';
+    if (value >= 1.5) {return 'positive';}
+    if (value >= 1) {return 'neutral';}
+    if (value < 0) {return 'negative';}
     return '';
   }
 
   getWinRateClass(value: number): string {
-    if (value >= 0.55) return 'positive';
-    if (value >= 0.45) return 'neutral';
+    if (value >= 0.55) {return 'positive';}
+    if (value >= 0.45) {return 'neutral';}
     return 'negative';
   }
 
   getProfitFactorClass(value: number): string {
-    if (value >= 1.5) return 'positive';
-    if (value >= 1) return 'neutral';
+    if (value >= 1.5) {return 'positive';}
+    if (value >= 1) {return 'neutral';}
     return 'negative';
   }
 }

apps/dashboard/src/app/pages/strategies/dialogs/backtest-dialog.component.ts

@@ -139,7 +139,7 @@ export class BacktestDialogComponent implements OnInit {
   }
 
   addSymbol(symbol: string): void {
-    if (!symbol || this.selectedSymbols.includes(symbol)) return;
+    if (!symbol || this.selectedSymbols.includes(symbol)) {return;}
     this.selectedSymbols.push(symbol);
   }
 

apps/dashboard/src/app/pages/strategies/dialogs/strategy-dialog.component.ts

@@ -126,7 +126,7 @@ export class StrategyDialogComponent implements OnInit {
   }
 
   addSymbol(symbol: string): void {
-    if (!symbol || this.selectedSymbols.includes(symbol)) return;
+    if (!symbol || this.selectedSymbols.includes(symbol)) {return;}
     this.selectedSymbols.push(symbol);
   }
 

apps/dashboard/src/app/pages/strategies/strategy-details/strategy-details.component.ts

@@ -67,7 +67,9 @@ export class StrategyDetailsComponent implements OnChanges {
   }
 
   loadStrategyData(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     // In a real implementation, these would call API methods to fetch the data
     this.loadSignals();
@@ -75,7 +77,9 @@ export class StrategyDetailsComponent implements OnChanges {
     this.loadPerformance();
   }
   loadSignals(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     this.isLoadingSignals = true;
 
@@ -100,7 +104,9 @@ export class StrategyDetailsComponent implements OnChanges {
   }
 
   loadTrades(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     this.isLoadingTrades = true;
 
@@ -140,7 +146,9 @@ export class StrategyDetailsComponent implements OnChanges {
     };
   }
   listenForUpdates(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     // Subscribe to strategy signals
     this.webSocketService.getStrategySignals(this.strategy.id).subscribe((signal: any) => {
@@ -186,7 +194,9 @@ export class StrategyDetailsComponent implements OnChanges {
    * Update performance metrics when new trades come in
    */
   private updatePerformanceMetrics(): void {
-    if (!this.strategy || this.trades.length === 0) return;
+    if (!this.strategy || this.trades.length === 0) {
+      return;
+    }
 
     // Calculate basic metrics
     const winningTrades = this.trades.filter(t => t.pnl > 0);
@@ -201,6 +211,8 @@ export class StrategyDetailsComponent implements OnChanges {
       ...currentPerformance,
       totalTrades: this.trades.length,
       winRate: winRate,
+      winningTrades,
+      losingTrades,
       totalReturn: (currentPerformance.totalReturn || 0) + totalPnl / 10000, // Approximate
     };
 
@@ -242,7 +254,9 @@ export class StrategyDetailsComponent implements OnChanges {
    * Open the backtest dialog to run a backtest for this strategy
    */
   openBacktestDialog(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     const dialogRef = this.dialog.open(BacktestDialogComponent, {
       width: '800px',
@@ -261,7 +275,9 @@ export class StrategyDetailsComponent implements OnChanges {
    * Open the strategy edit dialog
    */
   openEditDialog(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     const dialogRef = this.dialog.open(StrategyDialogComponent, {
       width: '600px',
@@ -280,7 +296,9 @@ export class StrategyDetailsComponent implements OnChanges {
    * Start the strategy
    */
   activateStrategy(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     this.strategyService.startStrategy(this.strategy.id).subscribe({
       next: response => {
@@ -298,7 +316,9 @@ export class StrategyDetailsComponent implements OnChanges {
    * Pause the strategy
    */
   pauseStrategy(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     this.strategyService.pauseStrategy(this.strategy.id).subscribe({
       next: response => {
@@ -316,7 +336,9 @@ export class StrategyDetailsComponent implements OnChanges {
    * Stop the strategy
    */
   stopStrategy(): void {
-    if (!this.strategy) return;
+    if (!this.strategy) {
+      return;
+    }
 
     this.strategyService.stopStrategy(this.strategy.id).subscribe({
       next: response => {
@@ -332,7 +354,9 @@ export class StrategyDetailsComponent implements OnChanges {
 
   // Methods to generate mock data
   private generateMockSignals(): any[] {
-    if (!this.strategy) return [];
+    if (!this.strategy) {
+      return [];
+    }
 
     const signals = [];
     const actions = ['BUY', 'SELL', 'HOLD'];
@@ -358,7 +382,9 @@ export class StrategyDetailsComponent implements OnChanges {
   }
 
   private generateMockTrades(): any[] {
-    if (!this.strategy) return [];
+    if (!this.strategy) {
+      return [];
+    }
 
     const trades = [];
     const now = new Date();

apps/dashboard/src/app/services/websocket.service.ts

@@ -1,5 +1,5 @@
 import { Injectable, signal } from '@angular/core';
-import { BehaviorSubject, Observable, Subject } from 'rxjs';
+import { Observable, Subject } from 'rxjs';
 import { filter, map } from 'rxjs/operators';
 
 export interface WebSocketMessage {
@@ -204,7 +204,7 @@ export class WebSocketService {
 
   // Cleanup
   disconnect() {
-    this.connections.forEach((ws, serviceName) => {
+    this.connections.forEach((ws, _serviceName) => {
       if (ws.readyState === WebSocket.OPEN) {
         ws.close();
       }